Improve advanced data filtering form

Description

Problems:

  • With the addition of the clinical diagnosis, it is easy to make a mistake (it is easy to mix them up with diseases)

  • Clinical diagnosis also needs to have options "all" and "at least one of the selected diseases" (not an issue, already done in PT-1986)

  • There are way too many "empty means no constraint"

  • No need for such wide fields

  • Currently the filtering form looks way too busy. When you are in the middle of the form one can not easily determine if the field labels are above or below them.

  • Rename "by disease" to "by final diagnosis"

Environment

None

Activity

Show:
Marta Girdea
April 9, 2017, 12:27 AM

Also, should the filters be expanded by default now?

Sasha Andjic
April 9, 2017, 7:33 AM
Edited

The panel looks really good. When I add large number of diseases, genes and phenotypes the panel grows together with the patient form. I kind of like the collapsed panel. It looks nice and it is impossible not to notice it. Here are few things that I found:

  • if we go with expanded filters, the default zoom needs to be lowered to 90% (same for Chrome and Safari)

  • currently we have only molecular diagnosis (clinical diagnosis is missing)

  • I'm not sure if we need "By" in the labels at all? This question is probably best suited for our new genetic counselor.

Marta Girdea
April 9, 2017, 8:12 AM

if we go with expanded filters, the default zoom needs to be lowered to 90% (same for Chrome and Safari)

Why? Can you share a screenshot?

currently we have only molecular diagnosis (clinical diagnosis is missing)

That's because dev is on a mutant version. Please ignore.

I'm not sure if we need "By" in the labels at all?

Sure, we can work on the labels, suggestions like this one are welcome. For now, this mockup is only about the layout.

Sasha Andjic
April 9, 2017, 4:30 PM

Zoom at 100%:

Sasha Andjic
May 9, 2017, 8:59 AM

I changed Molecular diagnosis to Final diagnosis

Fixed

Assignee

Marta Girdea

Reporter

Sasha Andjic

Labels

None

External issue ID

None

Fix versions

Priority

Medium