Pedigree node removal and redraw algorithm is sometimes terminated by a (silently hidden) exception

Description

The following line has a reference to an undefined variable `changedIDs`:
https://github.com/phenotips/phenotips/blob/master/components/pedigree/resources/src/main/resources/pedigree/view.js#L637

As a result in some cases when removing parts of the pedigree some code which is expected to run does not, which may cause all random kinds of problems. The error was silently eaten by a try-catch block, and I can not find an example which results in clearly visible problems, but this is obviously a bug

Environment

None

Activity

Show:
Andrew Misyura
March 21, 2017, 7:59 AM
Edited

when the relationship marked with red circle is removed from the pedigree on the picture below, one of the lines which is crossed by another line is being removed, which triggers the code which had a bug (and a new fix, which should also be tested):

Sasha Andjic
March 21, 2017, 11:02 AM

fyi I recreated the same pedigree and removed relationship marked in red in both rc1 and PR, the result was identical and weird looking (although correct).

Fixed

Assignee

Andrew Misyura

Reporter

Andrew Misyura

Labels

None

External issue ID

None

Epic Link

Components

Fix versions

Affects versions

Priority

Medium