The JS drag/drop library used by PhenoTips modal dialogues does not handle relative positioning well

Description

When a modal positioned relatively (e.g. `top: 35%`) is being dragged using a mouse it first jumps to the top of the screen, then returns to normal position (which is visually annoying)

The problem is in `dragdrop.js` code:

does not handle `this.element.top` being a percentage instead of an integer, so it moves the dialogue to the top (`top: 0px`)

Environment

None

Activity

Show:
Andrew Misyura
March 1, 2017, 10:34 PM

When working with that code can probably also add an option to PhenoTips modal dialogues to not be draggable off-screen (which is relevant for pedigree editor). DragDrop.js suports disabling dragging off visible area, but PhenoTips modal dialogue used by pedigree editor always enables this kind of dragging (maybe disable it there as well?)

Assignee

Andrew Misyura

Reporter

Andrew Misyura

Labels

None

External issue ID

None

Fix versions

Affects versions

Priority

Minor