Pedigree image may not correctly reflect the current state of the patient when patient data is modified outside pedigree editor

Description

Problem:

  • create new patient with causal gene

  • open pedigree editor and save it

  • make edits in the patient record form such as: modify status of casual gene to negative, add more genes, add phenotypes, diagnosis

  • save patient

  • export to PDF

  • the pedigree image does not reflect the latest changes

Please see: https://fsdemo.phenotips.org/P0000004

Environment

None

Activity

Show:
Sasha Andjic
October 7, 2016, 2:53 PM

I know, this is an old issue.

Andrew Misyura
October 7, 2016, 2:54 PM
Edited

Actually, thinking a bit more about this (as it became more relevant aparently), we only need a small part of pedigree running - not even the pedigree, just a small bit of code, which will just redraw the patient node independently of the pedigree editor, and then will update the stored SVG (replace shapes responsible to draw this patient's node with new set of shapes), which can bypass any locks since it does not affect actual data, and any (unlikely) conflict is fine and better than this image-data inconsistency. Actually, I like this idea more and more now

Andrew Misyura
October 7, 2016, 2:55 PM

> I know, this is an old issue.

then you shouldn't have created a new JIRA issue as we already have an issue for this. And while this is important, it can't be a blocker since then we wont release anything for a long time

Sasha Andjic
October 7, 2016, 2:56 PM

Sasha Andjic
October 7, 2016, 3:19 PM

Now with family studies on board, I see the full extent of this issue that I was not aware before. I just played with an entire family. I modified relevant info for every member without opening the pedigree editor. It does not look good when you see the wrong image in the patient form, family page, pdf export, png, svg.

Assignee

Andrew Misyura

Reporter

Sasha Andjic

Labels

External issue ID

None

Components

Fix versions

Priority

Major