Assign patient to the family modal improvement

Description

In "Assign patient to the family" modal move the Family name field right next to "Add to an existing family" button. The current position implies the Family name needs to be entered even if user wants to create a new one.

Also, when "Add to an existing family" button is chosen, it would be nice to move the focus to Family name field.
Right now user can tab to this field or click on it, which triggers "Add to an existing family" option to be automatically selected. I am not sure if this will cause some confusion with users ( e.g. they clicked on the field without realizing that they are now searching for existing families and not adding a new family).

Environment

None

Activity

Show:
Marta Girdea
March 16, 2017, 1:20 AM

But it's not done as described.

Sasha Andjic
March 16, 2017, 1:21 AM

We went back and forth with this one. I believe the current implementation is the one we all agreed.

Marta Girdea
March 16, 2017, 1:24 PM
Edited

I disagree. The issue proposes an obvious improvement, which is to focus the input when "Add to existing family" is selected. I've just made a PR with a 1 line commit for this fix.

Marta Girdea
March 16, 2017, 2:29 PM

Also committed some minor layout changes to the same PR, hoping to clarify that the input belongs with the "Add to existing family" option.

Before:

After:

Sasha Andjic
March 16, 2017, 2:40 PM

YAY!

Fixed

Assignee

Marta Girdea

Reporter

Sasha Andjic

Labels

None

External issue ID

None

Components

Fix versions

Priority

Medium