Uploaded image for project: 'PhenoTips'
  1. PT-2318

AbstractSpecializedNCBIEUtilsAccessService calls String.trim() without saving the result

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.2
    • Fix Version/s: 1.3-milestone-1
    • Component/s: None
    • Labels:
      None
    • Sprint:

      Description

      https://github.com/phenotips/phenotips/blob/432597d3d9db17df27f2bfafa09bac31d8921f6b/components/ncbieutils-services/api/src/main/java/org/phenotips/ncbieutils/internal/AbstractSpecializedNCBIEUtilsAccessService.java#L182

      Strings are immutable in Java, so just calling result.trim() does nothing. This line should either be changed to result = result.trim(); or deleted altogether.

        Attachments

          Activity

            People

            • Assignee:
              sdumitriu Sergiu Dumitriu
              Reporter:
              alex.henrie Alex Henrie
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: